docs(persona): the TUI says "attribute" too, not "fact" - #285
Merged
Conversation
The identity pane was the third surface `design-docs/persona-vocabulary.md` governs and the one left behind when the console and `pnm` were brought over. A tab was literally named *Your facts* and its form said *Add a fact*. The word was wrong in two independent ways. It asserts what the model cannot promise: everything in the pool is self-asserted until a credential backs it, and a face exists so a person may show an old value, a pinned version, a per-context override, or something untrue — the pane said *fact* directly above the provenance line that said *you said so*. And it was already taken: `Facts` is the VTC ceremony engine's term for a *verified* policy input. - tab `Your facts` → `Your attributes`; `Add a fact` → `Add an attribute` - `wears: work (3 facts)` → `(3 attributes)` in `BindingSummary::describe` - `no facts recorded`, `(unnamed fact)`, `Saved the fact`, `Forgot the fact`, `Could not read your facts` and the pane's guidance copy follow - the definition phrase is now the table's: *something you say about yourself, held once* - `the_pane_speaks_the_agreed_vocabulary` bans `fact` and permits `attribute`, with the reasoning inline so it is not "fixed" back Nothing in `openvtc-core::persona`'s types, the wire format or the task URIs moves — they always said `attribute`. Ordinary English (`after the fact`, `in fact`) is left alone. 446 + 520 + 28 tests pass; clippy and fmt clean. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
🛡️ AI Agentic Security Code Review🔎 A manual security review is recommended before merging. Please contact the Security team for specifics and remediation guidance.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The identity pane was the third surface
design-docs/persona-vocabulary.mdgoverns, and the one left behind when the console (OpenVTC/vta-browser-plugin#191) andpnm(OpenVTC/verifiable-trust-infrastructure#1319) were brought over. A tab was literally named Your facts and its form said Add a fact.The word was wrong in two independent ways.
It asserts what the model cannot promise. Everything in the pool is self-asserted until a credential backs it, and a face exists precisely so a person may show an old value, a pinned version, a per-context override, or something untrue. The pane said fact directly above the provenance line that said you said so.
And it was already taken.
Factsis the VTC ceremony engine's term for a verified policy input (vtc-service/src/ceremony/facts.rs, every.rego) — very nearly the opposite meaning, in the same product.What changed on screen
Your factsYour attributesAdd a fact/Edit a factAdd an attribute/Edit an attributewears: work (3 facts)wears: work (3 attributes)no facts recordedno attributes recorded(unnamed fact)(unnamed attribute)Saved the fact/Forgot the factSaved the attribute/Forgot the attributeCould not read your factsCould not read your attributesthe_pane_speaks_the_agreed_vocabularynow bansfactand permitsattribute, with the reasoning inline so it is not "fixed" back — that guard is the only mechanical enforcement this vocabulary has, and it caught the change the moment I made it.Untouched:
openvtc-core::personatypes, the wire format and task URIs (they always saidattribute), and ordinary English —after the fact,in fact.The companion
design-docs/persona-vocabulary.mdnow records all four surfaces and which one is still unaudited (the mobile agent, which inherits the VTA's card text but has not been read line by line).Verification
446 + 520 + 28 tests pass;
cargo clippy --all-targetsandcargo fmt --checkclean.